Skip to content

GH-104405: Add missing PEP 523 checks #104406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 12, 2023
Merged

GH-104405: Add missing PEP 523 checks #104406

merged 8 commits into from
May 12, 2023

Conversation

brandtbucher
Copy link
Member

@brandtbucher brandtbucher commented May 11, 2023 •
edited by bedevere-bot
Loading

Also, increase our test coverage of these instructions (and add a helpful assert for future ones).

This will need to be manually backported to 3.11.

@brandtbucher brandtbucher added type-bug An unexpected behavior, bug, or error interpreter-core (Objects, Python, Grammar, and Parser dirs) labels May 11, 2023
@brandtbucher brandtbucher requested a review from markshannon May 11, 2023 22:59
@brandtbucher brandtbucher self-assigned this May 11, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 11, 2023
Closed
AlexWaygood
AlexWaygood reviewed May 11, 2023
View reviewed changes
brandtbucher and others added 2 commits May 11, 2023 16:34
markshannon
markshannon approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@markshannon markshannon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the new tests fail on main.

@brandtbucher
Copy link
Member Author

I assume the new tests fail on main.

Yep.

Perf came back about 1% faster, thanks to our friend gc_traversal... 🙄

@brandtbucher brandtbucher enabled auto-merge (squash) May 12, 2023 21:56
@brandtbucher brandtbucher merged commit 1eb950c into python:main May 12, 2023
@brandtbucher brandtbucher mentioned this pull request May 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood left review comments

@markshannon markshannon markshannon approved these changes

Assignees

@brandtbucher brandtbucher

Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brandtbucher @markshannon @AlexWaygood @bedevere-bot