[3.11] gh-105834: Backport new tests for typing.Protocol (#105835)
#105860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…two protocols (python#105835) Some parts of the implementation of `typing.Protocol` had poor test coverage
AlexWaygood
requested review from
gvanrossum,
Fidget-Spinner and
JelleZijlstra
as code owners
This was referenced Jun 16, 2023
JelleZijlstra
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry-picked from commit 70c075c)
This actually backports some adjacent tests as well, which currently exist on
mainand3.12but not on3.11. These tests weren't part of #105835, but (1) the tests all pass on 3.11; (2) more test coverage never hurts; and (3) backporting these tests will reduce the risk of merge conflicts when backporting test-only PRs in the future.typing.py#105834