Skip to content

gh-107237: Fix test_udp_reconnection() of test_logging #107238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2023
Merged

gh-107237: Fix test_udp_reconnection() of test_logging #107238

merged 1 commit into from
Jul 25, 2023

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jul 25, 2023 •
edited by bedevere-bot
Loading

test_logging: Fix test_udp_reconnection() by increasing the timeout from 100 ms to 5 minutes (LONG_TIMEOUT).

Replace also blocking wait() with wait(LONG_TIMEOUT) in test_output() to prevent the test to hang.

@vstinner
pythongh-107237: Fix test_udp_reconnection() of test_logging
f2c961d 
test_logging: Fix test_udp_reconnection() by increasing the timeout
from 100 ms to 5 minutes (LONG_TIMEOUT).

Replace also blocking wait() with wait(LONG_TIMEOUT) in
test_output() to prevent the test to hang.
@vstinner vstinner requested a review from vsajip as a code owner July 25, 2023 12:37
@bedevere-bot bedevere-bot mentioned this pull request Jul 25, 2023
Closed
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Jul 25, 2023
@vstinner vstinner added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 25, 2023
@vstinner vstinner enabled auto-merge (squash) July 25, 2023 12:37
@vstinner vstinner merged commit ed08238 into python:main Jul 25, 2023
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-107242 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 25, 2023
@vstinner @miss-islington
pythongh-107237: Fix test_udp_reconnection() of test_logging (pythonG…
41a3b3b 
…H-107238)

test_logging: Fix test_udp_reconnection() by increasing the timeout
from 100 ms to 5 minutes (LONG_TIMEOUT).

Replace also blocking wait() with wait(LONG_TIMEOUT) in
test_output() to prevent the test to hang.
(cherry picked from commit ed08238)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 25, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 25, 2023
@vstinner @miss-islington
pythongh-107237: Fix test_udp_reconnection() of test_logging (pythonG…
9f69bc4 
…H-107238)

test_logging: Fix test_udp_reconnection() by increasing the timeout
from 100 ms to 5 minutes (LONG_TIMEOUT).

Replace also blocking wait() with wait(LONG_TIMEOUT) in
test_output() to prevent the test to hang.
(cherry picked from commit ed08238)

Co-authored-by: Victor Stinner <[email protected]>
@vstinner vstinner deleted the test_udp_reconnection branch July 25, 2023 13:31
@vstinner vstinner added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Jul 25, 2023
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 25, 2023
@vstinner @miss-islington
pythongh-107237: Fix test_udp_reconnection() of test_logging (pythonG…
fd6d9ed 
…H-107238)

test_logging: Fix test_udp_reconnection() by increasing the timeout
from 100 ms to 5 minutes (LONG_TIMEOUT).

Replace also blocking wait() with wait(LONG_TIMEOUT) in
test_output() to prevent the test to hang.
(cherry picked from commit ed08238)

Co-authored-by: Victor Stinner <[email protected]>
vstinner added a commit that referenced this pull request Jul 25, 2023
@miss-islington @vstinner
[3.12] gh-107237: Fix test_udp_reconnection() of test_logging (GH-107238
e788c0a 
) (#107242)

gh-107237: Fix test_udp_reconnection() of test_logging (GH-107238)

test_logging: Fix test_udp_reconnection() by increasing the timeout
from 100 ms to 5 minutes (LONG_TIMEOUT).

Replace also blocking wait() with wait(LONG_TIMEOUT) in
test_output() to prevent the test to hang.
(cherry picked from commit ed08238)

Co-authored-by: Victor Stinner <[email protected]>
@vstinner vstinner added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Jul 25, 2023
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 25, 2023
@vstinner @miss-islington
pythongh-107237: Fix test_udp_reconnection() of test_logging (pythonG…
0cfd3fb 
…H-107238)

test_logging: Fix test_udp_reconnection() by increasing the timeout
from 100 ms to 5 minutes (LONG_TIMEOUT).

Replace also blocking wait() with wait(LONG_TIMEOUT) in
test_output() to prevent the test to hang.
(cherry picked from commit ed08238)

Co-authored-by: Victor Stinner <[email protected]>
vstinner added a commit to vstinner/cpython that referenced this pull request Jul 25, 2023
@vstinner
pythongh-107237: Fix test_udp_reconnection() of test_logging (python#…
9bc5307 
…107238)

test_logging: Fix test_udp_reconnection() by increasing the timeout
from 100 ms to 5 minutes (LONG_TIMEOUT).

Replace also blocking wait() with wait(LONG_TIMEOUT) in
test_output() to prevent the test to hang.

(cherry picked from commit ed08238)
@bedevere-bot
Copy link

GH-107245 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 25, 2023
vstinner added a commit that referenced this pull request Jul 25, 2023
@vstinner
[3.11] gh-107237: Fix test_udp_reconnection() of test_logging (#107238)…
db03cb9 
… (#107245)

gh-107237: Fix test_udp_reconnection() of test_logging (#107238)

test_logging: Fix test_udp_reconnection() by increasing the timeout
from 100 ms to 5 minutes (LONG_TIMEOUT).

Replace also blocking wait() with wait(LONG_TIMEOUT) in
test_output() to prevent the test to hang.

(cherry picked from commit ed08238)
jtcave pushed a commit to jtcave/cpython that referenced this pull request Jul 27, 2023
@vstinner @jtcave
pythongh-107237: Fix test_udp_reconnection() of test_logging (python#…
df8fb86 
…107238)

test_logging: Fix test_udp_reconnection() by increasing the timeout
from 100 ms to 5 minutes (LONG_TIMEOUT).

Replace also blocking wait() with wait(LONG_TIMEOUT) in
test_output() to prevent the test to hang.
serhiy-storchaka pushed a commit that referenced this pull request Aug 16, 2023
@miss-islington @vstinner
[3.11] gh-107237: Fix test_udp_reconnection() of test_logging (GH-107238
4f35d4f 
) (GH-107243)

test_logging: Fix test_udp_reconnection() by increasing the timeout
from 100 ms to 5 minutes (LONG_TIMEOUT).

Replace also blocking wait() with wait(LONG_TIMEOUT) in
test_output() to prevent the test to hang.
(cherry picked from commit ed08238)

Co-authored-by: Victor Stinner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

Assignees
No one assigned
Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @miss-islington @bedevere-bot