gh-105539: Fix ResourceWarning from unclosed SQLite connection in ClosedCurTests. #108360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixxm
force-pushed
the
gh-105539-resource-warning
branch
2 times, most recently
from
0fe2b88 to
02851c2
Compare
erlend-aasland
approved these changes
Aug 23, 2023
…in tests. Follow up to 1a1bfc2. Co-authored-by: Erlend E. Aasland <[email protected]>
auto-merge was automatically disabled
August 23, 2023 09:21
Head branch was pushed to by a user without write access
felixxm
force-pushed
the
gh-105539-resource-warning
branch
from
02851c2 to
5c30ad3
Compare
|
@erlend-aasland I found and fixed one more: |
Good catch! |
|
Thanks, Mariusz! |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to 1a1bfc2.