gh-109118: Disallow nested scopes within PEP 695 scopes within classes #109196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carljm
approved these changes
Sep 11, 2023
Co-authored-by: Carl Meyer <[email protected]>
|
Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 12, 2023
…classes (pythonGH-109196) Fixes pythonGH-109118. Fixes pythonGH-109194. (cherry picked from commit b88d9e7) Co-authored-by: Jelle Zijlstra <[email protected]> Co-authored-by: Carl Meyer <[email protected]>
|
GH-109297 is a backport of this pull request to the 3.12 branch. |
Yhg1s
pushed a commit
that referenced
this pull request
Sep 12, 2023
… classes (GH-109196) (#109297) gh-109118: Disallow nested scopes within PEP 695 scopes within classes (GH-109196) Fixes GH-109118. Fixes GH-109194. (cherry picked from commit b88d9e7) Co-authored-by: Jelle Zijlstra <[email protected]> Co-authored-by: Carl Meyer <[email protected]>
vstinner
pushed a commit
to vstinner/cpython
that referenced
this pull request
Sep 13, 2023
…classes (python#109196) Fixes python#109118. Fixes python#109194. Co-authored-by: Carl Meyer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #109118. Fixes #109194.
See #109118 (comment).