Skip to content

GH-104584: Don't call executors from JUMP_BACKWARD #109347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 13, 2023
Merged

GH-104584: Don't call executors from JUMP_BACKWARD #109347

merged 2 commits into from
Sep 13, 2023

Conversation

brandtbucher
Copy link
Member

@brandtbucher brandtbucher commented Sep 12, 2023 •
edited by bedevere-app bot
Loading

Instead, rewind and let ENTER_EXECUTOR do its thing.

@brandtbucher brandtbucher added skip news interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Sep 12, 2023
@brandtbucher brandtbucher self-assigned this Sep 12, 2023
@bedevere-app bedevere-app bot mentioned this pull request Sep 12, 2023
Closed
gvanrossum
gvanrossum approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, needs a comment, let's wait for @markshannon.

@brandtbucher brandtbucher merged commit 6c13e13 into python:main Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

@brandtbucher brandtbucher

Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brandtbucher @gvanrossum