Skip to content

Conversation

dpr-0
Copy link
Contributor

@dpr-0 dpr-0 commented Nov 16, 2023

Issue a ResourceWarning instead.

(cherry picked from commit e0f5127) gh-109538: Avoid RuntimeError when StreamWriter is deleted with closed loop (#111983)

Issue a ResourceWarning instead.

Co-authored-by: Hugo van Kemenade [email protected]
(cherry picked from commit e0f5127)

… closed loop (python#111983)

Issue a ResourceWarning instead.

Co-authored-by: Hugo van Kemenade <[email protected]>
(cherry picked from commit e0f5127)
@dpr-0 dpr-0 requested review from 1st1 and asvetlov as code owners November 16, 2023 07:11
@bedevere-app bedevere-app bot added the type-bug An unexpected behavior, bug, or error label Nov 16, 2023
@dpr-0 dpr-0 changed the title [3.11] gh-109538: Catch closed loop runtime error and issue warning (GH-111983) [3.12] gh-109538: Catch closed loop runtime error and issue warning (GH-111983) Nov 16, 2023
@dpr-0 dpr-0 changed the title [3.12] gh-109538: Catch closed loop runtime error and issue warning (GH-111983) [3.11] gh-109538: Catch closed loop runtime error and issue warning (GH-111983) Nov 16, 2023
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks good. I guess this backported a test for this code.

Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay let’s merge this!

@gvanrossum gvanrossum merged commit 1397505 into python:3.11 Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants