gh-87804: Fix error handling and style in _pystatvfs_fromstructstatfs
#115236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colesbury
reviewed
Feb 12, 2024
| PyStructSequence_SET_ITEM(v, 7, | ||
| PyLong_FromLongLong((long long) st.f_ffree)); | ||
| PyStructSequence_SET_ITEM(v, 8, PyLong_FromLong((long) flags)); | ||
| #define SET_ITEM(v, index, item) \ |
There was a problem hiding this comment.
@sobolevn, the macro expansion of this will leak memory: item gets substituted as PyLong_FromLong, etc. at every occurrence, i.e.:
do {
if (PyLong_FromLong((long) st.f_iosize) == NULL) {
Py_DECREF(v);
return NULL;
}
PyStructSequence_SET_ITEM(v, 0, PyLong_FromLong((long) st.f_iosize));
} while (0)
There was a problem hiding this comment.
Oh, looks like you already figured it out 😊
|
Fix: #115335 |
fsc-eriker
pushed a commit
to fsc-eriker/cpython
that referenced
this pull request
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things I've fixed: