[3.12] gh-116333: Relax error string text expectations in SSL-related tests (GH-116334) #117136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tests (pythonGH-116334) * Relax error string text expectations in SSL-related tests As suggested [here][1], this change relaxes the OpenSSL error string text expectations in a number of tests. This was specifically done in support of more easily building CPython [AWS-LC][2], but because AWS-LC is a fork of [BoringSSL][3], it should increase compatibility with that library as well. In addition to the error string relaxations, we also add some guards around the `tls-unique` channel binding being used with TLSv1.3, as that feature (described in [RFC 6929][4]) is [not defined][5] for TLSv1.3. [1]: https://discuss.python.org/t/support-building-ssl-and-hashlib-modules-against-aws-lc/44505/4 [2]: https://github.com/aws/aws-lc [3]: https://github.com/google/boringssl [4]: https://datatracker.ietf.org/doc/html/rfc5929GH-section-3 [5]: https://datatracker.ietf.org/doc/html/rfc8446GH-appendix-C.5 (cherry picked from commit c85d841) Co-authored-by: Will Childs-Klein <[email protected]>
miss-islington
requested review from
a team,
1st1,
asvetlov,
gvanrossum,
kumaraditya303 and
willingc
as code owners
This was referenced Mar 21, 2024
gpshead
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested here, this change relaxes the OpenSSL error string
text expectations in a number of tests. This was specifically done in
support of more easily building CPython AWS-LC, but because AWS-LC
is a fork of BoringSSL, it should increase compatibility with that
library as well.
In addition to the error string relaxations, we also add some guards
around the
tls-uniquechannel binding being used with TLSv1.3, as thatfeature (described in RFC 6929) is not defined for TLSv1.3.
Co-authored-by: Will Childs-Klein [email protected]