Skip to content

GH-113464: Remove the extra jump via _SIDE_EXIT in _EXIT_TRACE #118545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2024
Merged

GH-113464: Remove the extra jump via _SIDE_EXIT in _EXIT_TRACE #118545

merged 1 commit into from
May 4, 2024

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented May 3, 2024 •
edited by bedevere-app bot
Loading

Currently, _EXIT_TRACE jumps to _SIDE_EXIT which then jumps to the exit.
With this PR _EXIT_TRACE jumps directly to the exit.

@markshannon markshannon requested a review from gvanrossum as a code owner May 3, 2024 11:47
@bedevere-app bedevere-app bot mentioned this pull request May 3, 2024
Closed
@markshannon markshannon requested a review from brandtbucher May 3, 2024 15:44
brandtbucher
brandtbucher approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simplification!

@markshannon markshannon merged commit da2cfc4 into python:main May 4, 2024
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
@markshannon @SonicField
pythonGH-113464: Remove the extra jump via _SIDE_EXIT in `_EXIT_TRA…
1e4281a 
…CE` (pythonGH-118545)
@markshannon markshannon deleted the inline-exits branch August 6, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markshannon @brandtbucher