[3.12] GH-117714: implement athrow().close() and asend().close() using throw (GH-117906) #118663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… throw (pythonGH-117906) * pythonGH-117714: replace athrow().close() and asend().close() stubs with implimentations * test athrow().close() and asend().close() raises RuntimeError * 📜🤖 Added by blurb_it. * Update Objects/genobject.c Co-authored-by: Petr Viktorin <[email protected]> --------- (cherry picked from commit e5c6992) Co-authored-by: Thomas Grainger <[email protected]> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Petr Viktorin <[email protected]>
|
I'm not sure if this is ok to backport, as it's a bugfix that resolves an omission |
|
It changes behaviour, and I don't think fixing this bug is particularly important. |
|
Sounds good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closing async_generator_athrow on an async generator that suppresses GeneratorExit does not raise RuntimeError #117714: replace athrow().close() and asend().close() stubs with implimentations
test athrow().close() and asend().close() raises RuntimeError
📜🤖 Added by blurb_it.
Update Objects/genobject.c
Co-authored-by: Petr Viktorin [email protected]
(cherry picked from commit e5c6992)
Co-authored-by: Thomas Grainger [email protected]
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Petr Viktorin [email protected]