remove reference to removed zipimporter._files attribute in module docstring #119015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
requested review from
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
willingc
approved these changes
May 13, 2024
zware
reviewed
May 13, 2024
zware
approved these changes
May 15, 2024
|
Thanks @graingert for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 15, 2024
…ythonGH-119015) (cherry picked from commit 7d722b7) Co-authored-by: Thomas Grainger <[email protected]>
|
GH-119071 is a backport of this pull request to the 3.13 branch. |
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attribute removed in 3.13 here 1fb9bd2
I thought it best to remove reference to the attribute rather than update it to _get_files()