Skip to content

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented May 21, 2024

The site module gets the main module to get _pyrepl.main.

The site module gets the __main__ module to get _pyrepl.__main__.
@lysnikolaou lysnikolaou added skip news topic-repl Related to the interactive shell labels May 21, 2024
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eugenetriguba
Copy link
Contributor

eugenetriguba commented May 21, 2024

@vstinner I took a crack at it here when I noticed the first PR that had the mypy fix reverted the bug fix: #119328. Do you have a preference of approach? Happy to close that one out or try to get that test properly working in that PR and just try to get that merged in instead 🙂

Copy link
Contributor

@danielhollas danielhollas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@vstinner vstinner enabled auto-merge (squash) May 21, 2024 18:55
@vstinner
Copy link
Member Author

Thanks for the review and testing!

@vstinner vstinner merged commit de8f530 into python:main May 21, 2024
@vstinner vstinner deleted the pyrepl_dumb2 branch May 21, 2024 20:33
@miss-islington-app
Copy link

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2024
The site module gets the __main__ module to get _pyrepl.__main__.
(cherry picked from commit de8f530)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented May 21, 2024

GH-119359 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 21, 2024
lysnikolaou pushed a commit that referenced this pull request May 22, 2024
The site module gets the __main__ module to get _pyrepl.__main__.
(cherry picked from commit de8f530)

Co-authored-by: Victor Stinner <[email protected]>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
The site module gets the __main__ module to get _pyrepl.__main__.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news topic-repl Related to the interactive shell
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants