Skip to content

gh-122170: Fix interpreter exiting due to ValueError from os.stat for too long filename on Windows #122175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

gh-122170: Fix interpreter exiting due to ValueError from os.stat for too long filename on Windows #122175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
15f0ada
Fix the interpreter exiting on Windows if a too long filename ends up…
devdanzin Jul 23, 2024
698ba3c
Fix another os.stat error in Windows if a too long filename in lineca…
devdanzin Jul 23, 2024
16237e4
Skip LineCacheTests.test_filename_too_long if not on Windows.
devdanzin Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Lib/linecache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ def updatecache(filename, module_globals=None):
fullname = filename
try:
stat = os.stat(fullname)
except OSError:
except (OSError, ValueError):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should not be suppressed on Unix platforms.

basename = filename

# Realise a lazy loader based lookup if there is one
Expand Down Expand Up @@ -135,7 +135,7 @@ def updatecache(filename, module_globals=None):
try:
stat = os.stat(fullname)
break
except OSError:
except (OSError, ValueError):
pass
else:
return []
Expand Down
4 changes: 4 additions & 0 deletions Lib/test/test_linecache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,10 @@ def test_loader(self):
self.assertEqual(linecache.getlines(filename, module_globals),
['source for x.y.z\n'])

@unittest.skipUnless(support.MS_WINDOWS, "Test only relevant in Windows.")
def test_filename_too_long(self):
self.assertEqual(linecache.updatecache("s" * 999999), [])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also check checkcache (which I forgot on my branch).



class LineCacheInvalidationTests(unittest.TestCase):
def setUp(self):
Expand Down
Loading