Skip to content

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 29, 2024

  • Authenticate socket connection for socket.socketpair() fallback when the platform does not have a native socketpair C API. We authenticate in-process using getsocketname and getpeername (thanks to Nathaniel J Smith for that suggestion).

(cherry picked from commit 78df104)

Co-authored-by: Seth Michael Larson [email protected]
Co-authored-by: Gregory P. Smith [email protected]

…r()` fallback (pythonGH-122134)

* Authenticate socket connection for `socket.socketpair()` fallback when the platform does not have a native `socketpair` C API.  We authenticate in-process using `getsocketname` and `getpeername` (thanks to Nathaniel J Smith for that suggestion).

(cherry picked from commit 78df104)

Co-authored-by: Seth Michael Larson <[email protected]>
Co-authored-by: Gregory P. Smith <[email protected]>
@picnixz
Copy link
Member

picnixz commented Jul 30, 2024

For the one responsible for fixing the backport: test.support.socket_helper does not exist on 3.8 so unittest.skipUnless(socket_helper.IPV6_ENABLED, 'IPv6 required for this test') will not work.

@ambv ambv merged commit 2621a8a into python:3.8 Jul 30, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-security A security issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants