gh-128550: TaskGroup: cancel tasks added to set after aborting #128551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
force-pushed
the
fix-taskgroup-eager
branch
from
41929bd to
9726c3d
Compare
|
I'm refactoring the tests to run the TaskGroup tests on eager and lazy tasks and have found another issue. I'm afk at the moment and will fix that one shortly too |
|
Ok I have the other issue here: #128553 |
graingert
commented
Jan 6, 2025
graingert
commented
Jan 6, 2025
graingert
commented
Jan 6, 2025
graingert
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
Misc/NEWS.d/next/Library/2025-01-06-18-58-07.gh-issue-128550.lzeWhZ.rst
Outdated
Show resolved
Hide resolved
graingert
commented
Jan 6, 2025
graingert
commented
Jan 6, 2025
graingert
commented
Jan 6, 2025
…zeWhZ.rst Co-authored-by: Peter Bierma <[email protected]>
ZeroIntensity
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.