Skip to content

gh-106320: Document replacement for removed C API #128787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 14, 2025
Merged

gh-106320: Document replacement for removed C API #128787

merged 3 commits into from
Jan 14, 2025

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jan 13, 2025 •
edited by github-actions bot
Loading

@vstinner vstinner added skip news needs backport to 3.13 bugs and security fixes labels Jan 13, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jan 13, 2025
Closed
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir awaiting core review labels Jan 13, 2025
@vstinner vstinner mentioned this pull request Jan 13, 2025
Merged
@vstinner
Copy link
Member Author

See also #128788.

clin1234
clin1234 suggested changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@clin1234 clin1234 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps also include a list of other removed private functions that don't have simple replacements for them?

Other than that, LGTM

@vstinner
Copy link
Member Author

vstinner commented Jan 13, 2025 •
edited
Loading

Perhaps also include a list of other removed private functions that don't have simple replacements for them?

Do you have examples?

Python 3.13 removed 263 private functions. I don't want to give the full list, especially if there is no simple replacement.

StanFromIreland
StanFromIreland reviewed Jan 13, 2025
View reviewed changes
@clin1234
Copy link
Contributor

  • _PyErr_WriteUnraisableMsg

@vstinner
Copy link
Member Author

_PyErr_WriteUnraisableMsg

Ok, I added _PyErr_WriteUnraisableMsg() replaced with PyErr_FormatUnraisable().

@vstinner vstinner merged commit 43ef958 into python:main Jan 14, 2025
25 checks passed
@vstinner vstinner deleted the removed_capi branch January 14, 2025 15:29
@miss-islington-app
Copy link

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 14, 2025
@vstinner @miss-islington
pythongh-106320: Document replacement for removed C API (pythonGH-128787
6baa1d4 
)

(cherry picked from commit 43ef958)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jan 14, 2025

GH-128837 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 14, 2025
vstinner added a commit that referenced this pull request Jan 14, 2025
@miss-islington @vstinner
[3.13] gh-106320: Document replacement for removed C API (GH-128787) (#…
d2a8d57 
…128837)

gh-106320: Document replacement for removed C API (GH-128787)
(cherry picked from commit 43ef958)

Co-authored-by: Victor Stinner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StanFromIreland StanFromIreland StanFromIreland left review comments

+1 more reviewer

@clin1234 clin1234 clin1234 requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
Docs PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @clin1234 @StanFromIreland