Skip to content

GH-131296: clang-cl on Windows: fix unused warning "self" in fileio.c #131303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

GH-131296: clang-cl on Windows: fix unused warning "self" in fileio.c #131303

wants to merge 2 commits into from

Conversation

chris-eibl
Copy link
Member

@chris-eibl chris-eibl commented Mar 15, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Mar 15, 2025
Closed
neonene
neonene reviewed Mar 17, 2025
View reviewed changes
Modules/_io/fileio.c Outdated
#ifdef HAVE_STRUCT_STAT_ST_BLKSIZE
fileio* self = PyFileIO_CAST(op);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the * position accidentally became inconsistent in this file, which could be unfriendly with some editors.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great spot!

Viusal Studio thinks it does me a favor when copy pasting -> it reformats :(

Now I found that evil setting and disabled it!

@chris-eibl chris-eibl closed this Mar 20, 2025
@chris-eibl
Copy link
Member Author

Done in #131487

@chris-eibl chris-eibl deleted the fix_clangcl_fileio branch March 20, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@neonene neonene neonene left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chris-eibl @neonene