Skip to content

gh-133158: Adjust c-analyzer max_sizes for typeobject.c #133159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

gh-133158: Adjust c-analyzer max_sizes for typeobject.c #133159

wants to merge 12 commits into from

Conversation

sergey-miryanov
Copy link
Contributor

@sergey-miryanov sergey-miryanov commented Apr 29, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Apr 29, 2025
Open
@sergey-miryanov
Copy link
Contributor Author

I believe this PR should skip news.

@sergey-miryanov
Copy link
Contributor Author

@ericsnowcurrently Please take a look.

@sergey-miryanov
Copy link
Contributor Author

@ericsnowcurrently Please take a look as you got time.

@sergey-miryanov sergey-miryanov mentioned this pull request Jul 22, 2025
Open
ZeroIntensity
ZeroIntensity reviewed Jul 22, 2025
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do my best to review this, but I'm not at all an expert here.

@sergey-miryanov
Copy link
Contributor Author

@ZeroIntensity Thanks for review!

@sergey-miryanov
Copy link
Contributor Author

Command to run (I always forgot it):
.\python.bat Tools/c-analyzer/check-c-globals.py --format summary Objects/typeobject.c

@sergey-miryanov
Copy link
Contributor Author

Fixed, thanks! It is ready for review.

ZeroIntensity
ZeroIntensity reviewed Jul 23, 2025
View reviewed changes
ZeroIntensity
ZeroIntensity reviewed Jul 28, 2025
View reviewed changes
ZeroIntensity
ZeroIntensity reviewed Aug 2, 2025
View reviewed changes
ZeroIntensity
ZeroIntensity approved these changes Aug 2, 2025
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm going to let this sit for a day or two before merging it.

@sergey-miryanov
Copy link
Contributor Author

Thanks for review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees
No one assigned
Labels
awaiting merge skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sergey-miryanov @ZeroIntensity @tomasr8