gh-42550: Add 'Expect: 100-Continue' support to httplib #133276
+287
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, http.client would always send content body immediately and ignore any 100 responses. This change makes HTTPClient.request() wait for a `Continue` response if the `Expect: 100-Continue` header is set, and adds a parameter to HTTPClient.getresponse() that will cause it to return 100 responses instead of eating them.
IngridMorstrad
changed the title
Misc/NEWS.d/next/Library/2019-07-22-00-57-26.bpo-1346874.TentEE.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Peter Bierma <[email protected]>
|
Hi, checking for a possible review on this. @ZeroIntensity |
|
Sorry, I was only triaging. I don't have enough knowledge on the |
AA-Turner
reviewed
Aug 14, 2025
Comment on lines
+49
to
+52
| sending a file-like message body. Finally, the optional *continue_timeout* | ||
| parameter controls how long the connection will wait for a ``100 Continue`` | ||
| response from the server before sending the body, if the request included | ||
| an ``Expect: 100-Continue`` header. |
There was a problem hiding this comment.
Does this need to be a constructor parameter?
|
You have merge conflicts, please resolve them before requesting a re-review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, http.client would always send content body immediately and ignore any 100 responses. This change makes HTTPClient.request() wait for a
Continueresponse if theExpect: 100-Continueheader is set, and adds a parameter to HTTPClient.getresponse() that will cause it to return 100 responses instead of eating them.#42550
https://bugs.python.org/issue1346874
📚 Documentation preview 📚: https://cpython-previews--133276.org.readthedocs.build/