[3.14] GH-128161: Remove redundant GET_ITER from list comprehension code #134778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markshannon
added
needs backport to 3.13
markshannon
force-pushed
the
dedup-getiter-listcomp
branch
from
e3d638b to
0e39bd3
Compare
|
This is for 3.14 and 3.13 only as #132555 contains the fix for 3.15 |
iritkatriel
reviewed
May 27, 2025
|
Do we have a test with the case described in the issue (#128161)? |
Yes, that's the new test added. |
iritkatriel
approved these changes
May 27, 2025
|
Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Sorry, @markshannon, I could not cleanly backport this to |
markshannon
added a commit
to faster-cpython/cpython
that referenced
this pull request
May 27, 2025
|
GH-134788 is a backport of this pull request to the 3.13 branch. |
markshannon
added a commit
that referenced
this pull request
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.