Skip to content

gh-109700: fix memory error handling in PyDict_SetDefault #136338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 6, 2025
Merged

gh-109700: fix memory error handling in PyDict_SetDefault #136338

merged 2 commits into from
Jul 6, 2025

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Jul 6, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jul 6, 2025
Open
@kumaraditya303 kumaraditya303 added interpreter-core (Objects, Python, Grammar, and Parser dirs) needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jul 6, 2025
serhiy-storchaka
serhiy-storchaka approved these changes Jul 6, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@kumaraditya303 kumaraditya303 enabled auto-merge (squash) July 6, 2025 14:53
@kumaraditya303 kumaraditya303 merged commit d22e073 into python:main Jul 6, 2025
40 checks passed
@miss-islington-app
Copy link

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 6, 2025
@kumaraditya303 @miss-islington
pythongh-109700: fix memory error handling in PyDict_SetDefault (py…
d62c8bc 
…thonGH-136338)

(cherry picked from commit d22e073)

Co-authored-by: Kumar Aditya <[email protected]>
@miss-islington-app
Copy link

Sorry, @kumaraditya303, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker d22e073d2b49313bbf42d40cbe74afa2b69385df 3.13

@bedevere-app
Copy link

bedevere-app bot commented Jul 6, 2025

GH-136340 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 6, 2025
kumaraditya303 added a commit that referenced this pull request Jul 6, 2025
@miss-islington @kumaraditya303
[3.14] gh-109700: fix memory error handling in PyDict_SetDefault (G…
5b65df7 
…H-136338) (#136340)

gh-109700: fix memory error handling in `PyDict_SetDefault` (GH-136338)
(cherry picked from commit d22e073)

Co-authored-by: Kumar Aditya <[email protected]>
@kumaraditya303 kumaraditya303 deleted the dict branch July 6, 2025 17:20
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
@kumaraditya303 @AndPuQing
pythongh-109700: fix memory error handling in PyDict_SetDefault (py…
3243ba1 
…thon#136338)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@kumaraditya303 @Pranjal095
pythongh-109700: fix memory error handling in PyDict_SetDefault (py…
b07a9f0 
…thon#136338)
picnixz pushed a commit to picnixz/cpython that referenced this pull request Jul 13, 2025
@kumaraditya303 @picnixz
pythongh-109700: fix memory error handling in PyDict_SetDefault (py…
6003abb 
…thon#136338)
@bedevere-app
Copy link

bedevere-app bot commented Jul 14, 2025

GH-136642 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 14, 2025
kumaraditya303 added a commit to kumaraditya303/cpython that referenced this pull request Jul 14, 2025
@kumaraditya303
pythongh-109700: fix memory error handling in PyDict_SetDefault (py…
fb64ff8 
…thon#136338)

(cherry picked from commit d22e073)
kumaraditya303 added a commit that referenced this pull request Jul 14, 2025
@kumaraditya303
[3.13] gh-109700: fix memory error handling in PyDict_SetDefault (#…
823bf76 
…136338) (#136642)

gh-109700: fix memory error handling in `PyDict_SetDefault` (#136338)

(cherry picked from commit d22e073)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@kumaraditya303 @taegyunkim
pythongh-109700: fix memory error handling in PyDict_SetDefault (py…
5e650b1 
…thon#136338)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@kumaraditya303 @Agent-Hellboy
pythongh-109700: fix memory error handling in PyDict_SetDefault (py…
18ff217 
…thon#136338)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@methane methane Awaiting requested review from methane methane is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

@kumaraditya303 kumaraditya303

Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kumaraditya303 @serhiy-storchaka