gh-132661: PEP 750 documentation: second pass #137020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
encukou
reviewed
Jul 23, 2025
|
Overall these changes look great to me. Thanks @AA-Turner ! About my only detail comment is that I tried to avoid using commas in examples so the reprs were easier to read. Hence "Hello World" without the comma. I'd be happy to see cheese-based examples make a comeback. :-) (Sorry for the slow review. I'm out of town on vacation right now -- back in another week.) |
# Conflicts: # Doc/reference/lexical_analysis.rst
|
Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 4, 2025
(cherry picked from commit 4dae9b1) Co-authored-by: Adam Turner <[email protected]>
|
GH-137392 is a backport of this pull request to the 3.14 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows on from #135229. cc @lysnikolaou @davepeck.
A
📚 Documentation preview 📚: https://cpython-previews--137020.org.readthedocs.build/