Skip to content

[3.14] gh-81325: Support path-like objects with streaming TarFile (GH-137188) #137365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 3.14
Choose a base branch
from
Open

[3.14] gh-81325: Support path-like objects with streaming TarFile (GH-137188) #137365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/tarfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ def __init__(self, name, mode, comptype, fileobj, bufsize,
fileobj = _StreamProxy(fileobj)
comptype = fileobj.getcomptype()

self.name = name or ""
self.name = os.fspath(name) if name is not None else ""
self.mode = mode
self.comptype = comptype
self.fileobj = fileobj
Expand Down
10 changes: 10 additions & 0 deletions Lib/test/test_tarfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1737,6 +1737,16 @@ def test_file_mode(self):
finally:
os.umask(original_umask)

def test_pathlike_name(self):
expected_name = os.path.abspath(tmpname)
tarpath = os_helper.FakePath(tmpname)

for func in (tarfile.open, tarfile.TarFile.open):
with self.subTest():
with func(tarpath, self.mode) as tar:
self.assertEqual(tar.name, expected_name)
os_helper.unlink(tmpname)


class GzipStreamWriteTest(GzipTest, StreamWriteTest):
def test_source_directory_not_leaked(self):
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2025-07-28-23-11-29.gh-issue-81325.jMJFBe.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
:class:`tarfile.TarFile` now accepts a :term:`path-like <path-like object>` when working on a tar archive.
(Contributed by Alexander Enrique Urieles Nieto in :gh:`81325`.)
Loading