Introduce a structure for .github/CODEOWNERS #137498

AA-Turner · 2025-08-07T01:20:46Z

The CODEOWNERS file is getting a little disorganised. This PR is an attempt to add more of a structure & grouping, so future entries are less slapdash. For example, I was unsure the best place to add new lines in #137483.

I've organised the file by 'topic area': CI, build systems, core interpreter, docs, misc, platforms, and stdlib. Entries are kept alphabetically within each top-level section, and are grouped/subtitled with a comment.

I have tried to ensure that thre are no behavioural changes to CODEOWNERS from this PR, but there is one exception -- I've removed the **/*cgi* entry as cgi.py etc was removed in 3.13.

Unresolved thoughts:

It would be nice to put the Windows build system in the build-systems section, but I don't know if we prefer keeping it with the platform support group, as it presently is.
I didn't have a good group for the interpreter-core tests (now labelled "tests"). For the rest of the old "Core" group, I've split it up into constituent parts (built in types, eval loop, compiler, core modules, tier 2 optimiser, etc).
I wasn't sure where best to put hashing / SSL -- it could go into either the "core" section or the "stdlib" section. (cc @picnixz for thoughts if any)
IDLE feels out of place in the "Misc" section, but it is bigger than just a stdlib module, so didn't feel right putting it there.

A

AA-Turner · 2025-08-07T01:22:07Z

Ah, ranges with [...] don't work.

ezio-melotti

ISTM that there are different possible approaches, each with pros and cons. Most of the entries seem to be about stdlib modules, built-in objects/functions¹, and the interpreter core. The other sections (with the exception of Platform Support) have fewer entries, and could possibly be grouped together in a single "Others".

I've seen tools that can inspect CODEOWNERS files, but I'm not sure if there is something that can detect unintentional changes between the old and the new version (I think I spot at least one -- contextlib). If you can find something it would be good to check that the owners are still the same.

This still looks like an improvement compared to the previous version, even in its current form.

FWIW in the docs both the built-in objects/functions and stdlibg modules are grouped under the "library" section, whereas here some objects are under Interpreter Core and others under Standard Library. ↩

.github/CODEOWNERS

ezio-melotti · 2025-08-07T02:43:00Z

.github/CODEOWNERS

-**/*pystate*                  @ericsnowcurrently @ZeroIntensity
-**/*preconfig*                @ericsnowcurrently
+# Context variables & HAMT
+**/contextvars*               @1st1


This used to be **/*context* (line 32 of the old file), which matched Lib/contextlib.py, but now contextlib doesn't seem to be matched by anything

I forgot to put this in the PR description. I think this was a mistaken glob that was over-expansive -- the PR (#5276) seemed to only reference context variables, rather than context managers.

@1st1 -- Yury, do you want to be listed as a codeowner for contextlib/context managers, or only for context variables?

.github/CODEOWNERS

Co-authored-by: Ezio Melotti <[email protected]>

picnixz · 2025-08-07T09:53:39Z

I am currently on a very bad network for today so I can only quickly reply: SSL and hashing can go under stdlib because none of them are built-ins. However hashing for Python objects (not cryptographic hashes) should go under core. Everything related to cryptography can go under a subsection of library named cryptographic primitives and applications (SSL is too much for being a primitive imo and it allows us to put more stuff related to cryptography in the future).

.github/CODEOWNERS

Co-authored-by: Hugo van Kemenade <[email protected]>

.github/CODEOWNERS

Co-authored-by: Ezio Melotti <[email protected]>

AA-Turner · 2025-08-18T16:57:49Z

Any further thoughts @hugovk @ezio-melotti? I've moved IDLE to the Standard Library section & have expanded the header/intro.

A

AA-Turner · 2025-08-25T15:38:49Z

It's been a week, I'll merge this soon absent any last-minute comments.

A

.github/CODEOWNERS

bedevere-bot · 2025-08-26T02:49:59Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL9 Refleaks 3.x (tier-3) has failed when building commit 73fb155.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1589/builds/2031) and take a look at the build logs.
Check if the failure is related to this commit (73fb155) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1589/builds/2031

Failed tests:

test.test_multiprocessing_fork.test_processes
test_external_inspection

Failed subtests:

test_interrupt - test.test_multiprocessing_fork.test_processes.WithProcessesTestProcess.test_interrupt
test_only_active_thread - test.test_external_inspection.TestGetStackTrace.test_only_active_thread

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/_test_multiprocessing.py", line 588, in test_interrupt
    exitcode = self._kill_process(multiprocessing.Process.interrupt)
  File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/_test_multiprocessing.py", line 570, in _kill_process
    self.assertEqual(join(), None)
                     ~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/_test_multiprocessing.py", line 250, in __call__
    return self.func(*args, **kwds)
           ~~~~~~~~~^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/process.py", line 156, in join
    res = self._popen.wait(timeout)
  File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/popen_fork.py", line 44, in wait
    return self.poll(os.WNOHANG if timeout == 0.0 else 0)
           ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/popen_fork.py", line 28, in poll
    pid, sts = os.waitpid(self.pid, flag)
               ~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/_test_multiprocessing.py", line 566, in handler
    raise RuntimeError('join took too long: %s' % p)
RuntimeError: join took too long: <Process name='Process-4' pid=3410653 parent=3410625 started daemon>


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/_test_multiprocessing.py", line 588, in test_interrupt
    exitcode = self._kill_process(multiprocessing.Process.interrupt)
  File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/_test_multiprocessing.py", line 570, in _kill_process
    self.assertEqual(join(), None)
                     ~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/_test_multiprocessing.py", line 250, in __call__
    return self.func(*args, **kwds)
           ~~~~~~~~~^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/process.py", line 156, in join
    res = self._popen.wait(timeout)
  File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/popen_fork.py", line 44, in wait
    return self.poll(os.WNOHANG if timeout == 0.0 else 0)
           ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/popen_fork.py", line 28, in poll
    pid, sts = os.waitpid(self.pid, flag)
               ~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/_test_multiprocessing.py", line 566, in handler
    raise RuntimeError('join took too long: %s' % p)
RuntimeError: join took too long: <Process name='Process-932' pid=3304496 parent=3297942 started daemon>


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/process.py", line 320, in _bootstrap
    self.run()
    ~~~~~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/_test_multiprocessing.py", line 518, in _sleep_some_event
    time.sleep(100)
    ~~~~~~~~~~^^^^^
KeyboardInterrupt
k


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-rhel9-s390x.refleak/build/Lib/test/test_external_inspection.py", line 1246, in test_only_active_thread
    self.assertEqual(
    ~~~~~~~~~~~~~~~~^
        len(gil_traces), 1, "Should have exactly one GIL holder"
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
AssertionError: 0 != 1 : Should have exactly one GIL holder

picnixz · 2025-08-26T10:21:57Z

.github/CODEOWNERS

+# code, and tests for a given item should all be listed in the same place.
+#
+# GitHub usernames should be aligned to column 31, or the next multiple
+# of three if the relevant paths are too long to fit.


I'm sorry I missed the reviewing part, but what's the rationale of having it on a multiple of 3? with a multiple of 4, we're able to use tabs to align it.

It is/was the pattern used in the file already. I don't know why it was first used, though.

Introduce a structure for .github/CODEOWNERS

b3899e8

AA-Turner requested review from ezio-melotti and hugovk as code owners August 7, 2025 01:20

bedevere-app bot added the awaiting core review label Aug 7, 2025

AA-Turner added skip issue skip news labels Aug 7, 2025

fixup! Introduce a structure for .github/CODEOWNERS

eff50a0

ezio-melotti reviewed Aug 7, 2025

View reviewed changes

AA-Turner and others added 2 commits August 7, 2025 04:42

Update .github/CODEOWNERS

7752d7c

Co-authored-by: Ezio Melotti <[email protected]>

Update .github/CODEOWNERS

002fed4

Co-authored-by: Ezio Melotti <[email protected]>

StanFromIreland added infra CI, GitHub Actions, buildbots, Dependabot, etc. type-refactor Code refactoring (with no changes in behavior) labels Aug 7, 2025

hugovk reviewed Aug 7, 2025

View reviewed changes

AA-Turner and others added 7 commits August 7, 2025 21:31

Alphabetical

0d5ca37

Co-authored-by: Hugo van Kemenade <[email protected]>

Review feedback

9edad9c

left-align

dae0424

fixup! left-align

ecbc05d

fixup! left-align

3a92f47

Alphabetical

0b80983

fixup! Alphabetical

6c15b23

AA-Turner requested review from hugovk and ezio-melotti August 11, 2025 00:33

ezio-melotti reviewed Aug 11, 2025

View reviewed changes

Apply suggestions from code review

1f74aee

Co-authored-by: Ezio Melotti <[email protected]>

AA-Turner mentioned this pull request Aug 15, 2025

Prune entries from the Experts Index python/devguide#1635

Open

AA-Turner added 3 commits August 18, 2025 17:51

Add exclusions section to the summary

b4096e4

Move IDLE

405e717

Rename "Misc" to "Internal Tools & Data"

bc5facc

AA-Turner commented Aug 26, 2025

View reviewed changes

.github/CODEOWNERS Outdated Show resolved Hide resolved

Update CODEOWNERS

04190bc

AA-Turner commented Aug 26, 2025

View reviewed changes

.github/CODEOWNERS Outdated Show resolved Hide resolved

.github/CODEOWNERS Outdated Show resolved Hide resolved

.github/CODEOWNERS Outdated Show resolved Hide resolved

.github/CODEOWNERS Outdated Show resolved Hide resolved

.github/CODEOWNERS Outdated Show resolved Hide resolved

Apply suggestions from code review

9019bdf

AA-Turner commented Aug 26, 2025

View reviewed changes

.github/CODEOWNERS Outdated Show resolved Hide resolved

Update CODEOWNERS

4f72bb2

AA-Turner merged commit 73fb155 into python:main Aug 26, 2025
25 checks passed

bedevere-app bot removed the awaiting core review label Aug 26, 2025

picnixz reviewed Aug 26, 2025

View reviewed changes

AA-Turner deleted the codeowners-structure branch August 26, 2025 12:02

Uh oh!

Introduce a structure for .github/CODEOWNERS #137498

Introduce a structure for .github/CODEOWNERS #137498

Conversation

AA-Turner commented Aug 7, 2025

Uh oh!

AA-Turner commented Aug 7, 2025

Uh oh!

ezio-melotti left a comment

Choose a reason for hiding this comment

Footnotes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ezio-melotti Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

AA-Turner Aug 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

picnixz commented Aug 7, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AA-Turner commented Aug 18, 2025

Uh oh!

AA-Turner commented Aug 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Aug 26, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

picnixz Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

AA-Turner Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!