gh-92936: update http.cookies docs post GH-113663
#137566
Conversation
bedevere-app
bot
added
awaiting review
docs
picnixz
changed the title
http.cookies docs post GH-113663
nburns
force-pushed
the
update-http-cookie-docs-example
branch
from
1416a5f to
8598956
Compare
nburns
force-pushed
the
update-http-cookie-docs-example
branch
from
8598956 to
75803bc
Compare
|
Please avoid force-pushing. It makes incremental review harder. We squash-merge commits at the end. |
Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
|
I sure will, thanks for all your help! |
Co-authored-by: Senthil Kumaran <[email protected]>
Doc/whatsnew/3.15.rst
Outdated
| * Allow ``"`` double quotes in cookie values with a more linient regex for | ||
| double-quoted strings. |
There was a problem hiding this comment.
Can we be more specific about what's changed than "a more lenient regex"? For example, do we now properly conform to an RFC/web specification? Are there restrictions that still exist on double-quoted strings?
| * Allow ``"`` double quotes in cookie values with a more linient regex for | |
| double-quoted strings. | |
| * Allow '``"``' double quotes in cookie values with a more lenient regex for | |
| double-quoted strings. |
Co-authored-by: Adam Turner <[email protected]>
Doc/whatsnew/3.15.rst
Outdated
| * Allow '``"``' double quotes in cookie values with a more lenient regex for | ||
| double-quoted strings. |
There was a problem hiding this comment.
| * Allow '``"``' double quotes in cookie values with a more lenient regex for | |
| double-quoted strings. | |
| * Allow '``"``' double quotes in cookie values with a more lenient regex for | |
| double-quoted strings by not explicitly excluding a quote inside the value part of a cookie. |
It's pretty similar to what was there before, just doesn't exclude the quotes: https://github.com/python/cpython/pull/113663/files#diff-e49aab1421911b035542d1a9221c31b8c74053f0e8b28f90f03af66177026176R429
There was a problem hiding this comment.
This is becoming little too detailed for a whatsnew item. Since it is both a bugfix and behavior change (ref #137566 (comment))
We could say - "Allow '"' double quotes in cookie values" or the existing detail is fine with me.
@AA-Turner, what is your suggestion here?
There was a problem hiding this comment.
Personally I'm a fan of the shorter
"Allow '"' double quotes in cookie values"
There was a problem hiding this comment.
I am good with the shorter version too. It is clear without confusing on the internal details like lenient regex (which the reader of whatsnew doc doesn't need to bother about) and if they really want they could refer to git log, bug report and other discussions.
|
LGTM. |
|
@orsenthil and everyone else, just wanted to say thanks for working with me on my first contribution to Python ❤️ |
#92936 (comment)
Updates
http.cookiedocs to reflect changes from #113663📚 Documentation preview 📚: https://cpython-previews--137566.org.readthedocs.build/