-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
gh-137777: Fix remove Program Frameworks chapter and relocate its modules #137796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Moved turtle docs under "Graphical User Interfaces with Tk" - Moved cmd docs under "Command Line Interface Libraries" - Moved shlex docs under "Unix Specific Services" - Removed Program Frameworks from the library TOC - Added orphan page at library/frameworks.rst with links to new locations to avoid 404s for existing inbound links
I think the document path is wrong. Let me check :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I checked that the preview page is well rendered too :)
https://cpython-previews--137796.org.readthedocs.build/en/137796/library/frameworks.html
Let's wait @AA-Turner and @hugovk for the English feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I'm thinking about where to put the modules in their new locations. Should the be added to the end of the list, or put somewhere more prominent further up the list.
I don't have a strong position on the following, it's kind of based on my use of the libraries, which is far from objective :)
-
I think
cmd
is okay at the end; the others look more important to me. -
I was going to suggest putting
shlex
second, afterposix
; butposix
begins with a warning: "Do not import this module directly". So maybe putshlex
first? -
turtle
is important for education, but perhaps not if you're specifically reading the "Graphical user interfaces with Tk" chapter, and last position is fine?
Doc/library/tk.rst
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's update this file's header to sentence case:
-Graphical User Interfaces with Tk
+Graphical user interfaces with Tk
Thanks for the guidance! |
I have a strong and objective position here: alphabetical order. :) It makes it easier for everyone to locate a module, but mainly for blind users of screen readers. Edit: another issue/PR could make this change for every chapter listing modules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good!
I'll leave this open for a bit in case Adam wants to check it.
This also makes it easier to decide/debate what order to put things in :) Looks okay to do this for We'd have to take care with "Graphical User Interfaces with Tk", would it make sense to start with the current
And they render like this, according to titles not filenames, where
Yeah, probably better to discuss separately from this one. |
Yeah. The order must be according to the title (what the reader sees), not filenames. The problem here is that "Tkinter Dialogs" is not a module itself, but something like a sub-chapter (why isn't tkinter.colorchooser — Color choosing dialog here ?). I think "Graphical User Interfaces with Tk" deserves its discussion. I've touched on this in the initial post. For now, "Tkinter Dialogs" could come after |
Thanks @rimi0108 for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
…37796) (cherry picked from commit eee6589) Co-authored-by: rimchoi <[email protected]>
…37796) (cherry picked from commit eee6589) Co-authored-by: rimchoi <[email protected]>
GH-137830 is a backport of this pull request to the 3.14 branch. |
GH-137831 is a backport of this pull request to the 3.13 branch. |
#137831) Co-authored-by: rimchoi <[email protected]>
📚 Documentation preview 📚: https://cpython-previews--137796.org.readthedocs.build/