-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
gh-135661: Fix parsing unterminated bogus comments in HTMLParser #137873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
serhiy-storchaka
merged 1 commit into
python:main
from
serhiy-storchaka:htmlparser-bogus-comment-cdata-eof
Aug 17, 2025
Merged
gh-135661: Fix parsing unterminated bogus comments in HTMLParser #137873
serhiy-storchaka
merged 1 commit into
python:main
from
serhiy-storchaka:htmlparser-bogus-comment-cdata-eof
Aug 17, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bogus comments that start with "<![CDATA[" should not include the starting "!" in its value.
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
Sorry, @serhiy-storchaka, I could not cleanly backport this to
|
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 17, 2025
pythonGH-137873) Bogus comments that start with "<![CDATA[" should not include the starting "!" in its value. (cherry picked from commit 7636a66) Co-authored-by: Serhiy Storchaka <[email protected]>
GH-137875 is a backport of this pull request to the 3.13 branch. |
Backport to 3.14 was included in #137772. |
serhiy-storchaka
added a commit
that referenced
this pull request
Aug 17, 2025
…er (GH-137873) (GH-137875) Bogus comments that start with "<![CDATA[" should not include the starting "!" in its value. (cherry picked from commit 7636a66) Co-authored-by: Serhiy Storchaka <[email protected]>
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
pythonGH-137873) Bogus comments that start with "<![CDATA[" should not include the starting "!" in its value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bogus comments that start with "<![CDATA[" should not include the starting "!" in its value.