Skip to content

gh-135661: Fix parsing unterminated bogus comments in HTMLParser #137873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Aug 17, 2025

Bogus comments that start with "<![CDATA[" should not include the starting "!" in its value.

Bogus comments that start with "<![CDATA[" should not include the starting "!"
in its value.
@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Aug 17, 2025
@serhiy-storchaka serhiy-storchaka changed the title gh-135661: Fix parsing unterminated bogus in HTMLParser gh-135661: Fix parsing unterminated bogus comments in HTMLParser Aug 17, 2025
@serhiy-storchaka serhiy-storchaka merged commit 7636a66 into python:main Aug 17, 2025
50 checks passed
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 7636a66635a0da849cfccd06a52d0a21fb692271 3.14

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 17, 2025
pythonGH-137873)

Bogus comments that start with "<![CDATA[" should not include the starting "!"
in its value.
(cherry picked from commit 7636a66)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Aug 17, 2025

GH-137875 is a backport of this pull request to the 3.13 branch.

@serhiy-storchaka
Copy link
Member Author

Backport to 3.14 was included in #137772.

@serhiy-storchaka serhiy-storchaka deleted the htmlparser-bogus-comment-cdata-eof branch August 17, 2025 10:45
serhiy-storchaka added a commit that referenced this pull request Aug 17, 2025
…er (GH-137873) (GH-137875)

Bogus comments that start with "<![CDATA[" should not include the starting "!"
in its value.
(cherry picked from commit 7636a66)

Co-authored-by: Serhiy Storchaka <[email protected]>
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
pythonGH-137873)

Bogus comments that start with "<![CDATA[" should not include the starting "!"
in its value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant