Skip to content

[3.7] bpo-22347: Update mimetypes.guess_type to allow proper parsing of URLs (GH-15522) #15687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2019
Merged

[3.7] bpo-22347: Update mimetypes.guess_type to allow proper parsing of URLs (GH-15522) #15687

merged 1 commit into from
Sep 5, 2019

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Sep 5, 2019 •
edited by miss-islington
Loading

https://bugs.python.org/issue22347
(cherry picked from commit 87bd207)

https://bugs.python.org/issue22347

Automerge-Triggered-By: @maxking

@corona10 corona10 requested a review from a team as a code owner September 5, 2019 00:49
@bedevere-bot bedevere-bot mentioned this pull request Sep 5, 2019
Merged
@corona10
Copy link
Member Author

corona10 commented Sep 5, 2019

cc @maxking

maxking
maxking approved these changes Sep 5, 2019
View reviewed changes
Copy link
Contributor

@maxking maxking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miss-islington
Copy link
Contributor

@corona10: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 8873bff into python:3.7 Sep 5, 2019
@corona10 corona10 deleted the backport-87bd207-3.7 branch September 5, 2019 01:22
@corona10 corona10 mentioned this pull request Oct 12, 2019
Closed
maxking added a commit that referenced this pull request Oct 12, 2019
@maxking
Revert "[3.7] bpo-22347: Update mimetypes.guess_type to allow proper …
455869a 
…parsing of URLs (GH-15522) (GH-15687)"

This reverts commit 8873bff.
@maxking maxking mentioned this pull request Oct 12, 2019
Merged
miss-islington pushed a commit that referenced this pull request Oct 12, 2019
@maxking @miss-islington
[3.7] bpo-38449: Revert "bpo-22347: Update mimetypes.guess_type to al…
164bee2 
…low oper parsing of URLs (GH-15685)" (GH-16724) (GH-16727)

Reverts GH-15687 which caused the issue.


https://bugs.python.org/issue22347

https://bugs.python.org/issue38449
ned-deily pushed a commit to ned-deily/cpython that referenced this pull request Oct 14, 2019
@maxking @ned-deily
[3.7] bpo-38449: Revert "bpo-22347: Update mimetypes.guess_type to al…
2a40559 
…low oper parsing of URLs (pythonGH-15685)" (pythonGH-16724) (pythonGH-16727)

Reverts pythonGH-15687 which caused the issue.


https://bugs.python.org/issue22347

https://bugs.python.org/issue38449
@vadmium vadmium mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@maxking maxking maxking approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@corona10 @miss-islington @maxking @the-knights-who-say-ni @bedevere-bot