Skip to content

bpo-39965: Correctly raise SyntaxError if await is used outside async functions when PyCF_ALLOW_TOP_LEVEL_AWAIT is set #19010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2020
Merged

bpo-39965: Correctly raise SyntaxError if await is used outside async functions when PyCF_ALLOW_TOP_LEVEL_AWAIT is set #19010

merged 1 commit into from
Mar 15, 2020

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Mar 15, 2020 •
edited
Loading

@pablogsal
bpo-39965: Correctly raise SyntaxError if await is used outside async…
de1ddfb 
… functions when PyCF_ALLOW_TOP_LEVEL_AWAIT is set
@pablogsal pablogsal changed the title bpo-39562: Correctly raise SyntaxError if await is used outside async functions when PyCF_ALLOW_TOP_LEVEL_AWAIT is set bpo-39965: Correctly raise SyntaxError if await is used outside async functions when PyCF_ALLOW_TOP_LEVEL_AWAIT is set Mar 15, 2020
@pablogsal pablogsal added needs backport to 3.8 type-bug An unexpected behavior, bug, or error labels Mar 15, 2020
@pablogsal pablogsal merged commit 9023581 into python:master Mar 15, 2020
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@pablogsal pablogsal deleted the no-async branch March 15, 2020 04:29
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 15, 2020
@pablogsal @miss-islington
bpo-39965: Correctly raise SyntaxError if await is used outside async…
155acde 
… functions when PyCF_ALLOW_TOP_LEVEL_AWAIT is set (pythonGH-19010)

(cherry picked from commit 9023581)

Co-authored-by: Pablo Galindo <[email protected]>
@bedevere-bot
Copy link

GH-19011 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Mar 15, 2020
@miss-islington @pablogsal
bpo-39965: Correctly raise SyntaxError if await is used outside async…
f7e32fc 
… functions when PyCF_ALLOW_TOP_LEVEL_AWAIT is set (GH-19010)

(cherry picked from commit 9023581)

Co-authored-by: Pablo Galindo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isidentical isidentical isidentical approved these changes

Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pablogsal @miss-islington @bedevere-bot @isidentical @the-knights-who-say-ni