bpo-40529: rlcompleter with case insensitive #19957
Conversation
Added an option to the user to make completions with case insensitive / sensitive. rlcompleter.set_case_insensitive(True) # to enable case insensitive Added documentation accordingly. * skip news
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
There was a problem hiding this comment.
Hi @kasulamadhusudhan, thanks for your contribution! You will have to sign the CLA to get this change accepted if you did not do it yet.
This change will also need to be documented at Doc/library/rlcompleter.rst and have some tests before it can be accepted.
Incorporated review comments @ Lib/rlcompleter.py Added documentation @ Doc/library/rlcompleter.rst Added unit testcase test_case_insentive_matches() @ Lib/test/test_rlcompleter.py * skip news
Changed func name set_case_insensitive() -> set_ignore_case() Modified Docs and Tests accordingly * skip news
|
Please review this. |
|
@kasulamadhusudhan, I'm sorry for the great delay until someone could give some attention to the issue and this PR. I'd be happy to review this, pending conclusion of the discussion on the issue. I'm adding the "do-not-merge" tag just to make this status clearer. I do feel that this has a good chance of being merged. |
|
Also, this will need an accompanying NEWS entry, which will need to be added to this PR (using |
Added an option to the user to make completions with case insensitive / sensitive.
rlcompleter.set_case_insensitive(True) # to enable case insensitive
Added documentation accordingly.
https://bugs.python.org/issue40529