Skip to content

bpo-1635741: Adapt _multibytecodec to multi-phase initialization #24095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jan 4, 2021
Merged

bpo-1635741: Adapt _multibytecodec to multi-phase initialization #24095

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
863d974
Add empty module state
Jan 4, 2021
c2c8b04
Convert encoder and decoder types to heap type
Jan 4, 2021
2e7e452
Convert reader and writer types to heap type
Jan 4, 2021
5eb463f
Convert multibytecode type to heap type
Jan 4, 2021
85ed337
Support multi-phase init
Jan 4, 2021
f30a096
Add NEWS
Jan 4, 2021
1c9e8ba
Fix type names
Jan 4, 2021
dc73713
Address review: Improve NEWS text
Jan 4, 2021
1b5b9fd
Address review: Improve naming
Jan 4, 2021
94c15cb
Address review: Add MODULE_NAME macro
Jan 4, 2021
15205cf
Address review: Fix macro indent
Jan 4, 2021
6bae5b1
Update Modules/cjkcodecs/multibytecodec.c
Jan 4, 2021
b1f3f3b
Address review: undef ADD_TYPE and CREATE_TYPE macros to better show …
Jan 4, 2021
e8b3021
Collect AC def's and scope clinic_get_state()
Jan 4, 2021
883f766
Address review: Improve NEWS again
Jan 4, 2021
18c1829
Rename __methods to _multibytecodec_methods for consistency
Jan 4, 2021
bf3da94
Fix rename
Jan 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add empty module state
  • Loading branch information
Erlend E. Aasland committed Jan 4, 2021
commit 863d9748857c41a9cac350e7ad77b7240ad30727
16 changes: 7 additions & 9 deletions Modules/cjkcodecs/multibytecodec.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@
#include "multibytecodec.h"
#include "clinic/multibytecodec.c.h"

typedef struct {
} _multibytecodec_state;

/*[clinic input]
module _multibytecodec
class _multibytecodec.MultibyteCodec "MultibyteCodecObject *" "&MultibyteCodec_Type"
Expand Down Expand Up @@ -2045,15 +2048,10 @@ static struct PyMethodDef __methods[] = {


static struct PyModuleDef _multibytecodecmodule = {
PyModuleDef_HEAD_INIT,
"_multibytecodec",
NULL,
-1,
__methods,
NULL,
NULL,
NULL,
NULL
.m_base = PyModuleDef_HEAD_INIT,
.m_name = "_multibytecodec",
.m_size = sizeof(_multibytecodec_state),
.m_methods = __methods,
};

PyMODINIT_FUNC
Expand Down