Skip to content

gh-84461: Add ability for multiprocessed libregrtest to use a different Python executable #91930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 2, 2022
Merged

gh-84461: Add ability for multiprocessed libregrtest to use a different Python executable #91930

merged 3 commits into from
May 2, 2022

Conversation

emmatyping
Copy link
Member

@emmatyping emmatyping commented Apr 25, 2022 •
edited by brettcannon
Loading

wasm32-emscripten does not support subprocesses. As a workaround, we can run the regression test suite with e.g. the system-native Python used for cross building, then execute the actual subprocess workers with the emscripten/target runtime.

For example, consider a setup where you have two folders: linux, which includes a build of CPython for linux and the native architecture of the machine. You also have wasm, which is the cross compiled Python for emscripten/node.

This PR would enable you to do linux/python -m test -j1 -p "node wasm/python.js", to run the test suite workers in nodejs.

@emmatyping emmatyping mentioned this pull request Apr 26, 2022
Merged
4 tasks
@brettcannon
Copy link
Member

@ethanhs can you add a news file?

@miss-islington
Copy link
Contributor

@ethanhs: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor

@ethanhs: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: 4 of 7 required status checks are expected..

@miss-islington
Copy link
Contributor

@ethanhs: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: 4 of 7 required status checks are expected..

1 similar comment
@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: 4 of 7 required status checks are expected..

@miss-islington
Copy link
Contributor

@ethanhs: Status check is done, and it's a success ✅ .

2 similar comments
@miss-islington
Copy link
Contributor

@ethanhs: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor

@ethanhs: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: 4 of 7 required status checks are expected..

2 similar comments
@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: 4 of 7 required status checks are expected..

@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: 4 of 7 required status checks are expected..

@miss-islington
Copy link
Contributor

@ethanhs: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: Head branch was modified. Review and try the merge again..

@brettcannon brettcannon merged commit aff8c4f into python:main May 2, 2022
@emmatyping emmatyping deleted the test_host_python branch May 8, 2022 02:13
@tiran tiran mentioned this pull request Jun 21, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon brettcannon approved these changes

@tiran tiran Awaiting requested review from tiran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emmatyping @brettcannon @miss-islington @bedevere-bot