gh-98762: Fix locations of match sub-patterns #98775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iritkatriel
added
type-bug
iritkatriel
commented
Oct 27, 2022
Misc/NEWS.d/next/Core and Builtins/2022-10-27-16-42-16.gh-issue-98762.Eb2kzg.rst
Outdated
Show resolved
Hide resolved
markshannon
reviewed
Oct 31, 2022
There was a problem hiding this comment.
Looks fine to me, but I'll leave it to @brandtbucher to review as he wrote the pattern matching code.
brandtbucher
approved these changes
Nov 11, 2022
Misc/NEWS.d/next/Core and Builtins/2022-10-27-16-42-16.gh-issue-98762.Eb2kzg.rst
Outdated
Show resolved
Hide resolved
brandtbucher
changed the title
Co-authored-by: Brandt Bucher <[email protected]>
Co-authored-by: Brandt Bucher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the recursive updates which made the locations incorrect.
They are still too broad in some cases, but we should deal with the separately. (One thing we would need to do is to save the locations of identifiers alongside the "stores" list.)