Skip to content

Type ignore comments erroneously marked as unused by dmypy #15043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 21, 2025
Merged

Type ignore comments erroneously marked as unused by dmypy #15043

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
1ce2f21
Add test to demonstrate issue #9655
meshy Mar 4, 2023
7d9c06a
Prove ignores without error codes also disappear
meshy Mar 12, 2023
9cd625d
Prove possibly-undefined errors disappear
meshy Mar 12, 2023
94e5df4
Test run-running dmypy after a file is altered
meshy Mar 31, 2023
b5cc83f
Add failing tests showing disappearing errors
meshy Apr 13, 2023
99eda13
Fix disappearing errors when re-running dmypy check
meshy Jul 20, 2023
d798c5a
Add a regression test for type ignores in dmypy
meshy Apr 12, 2023
ad94241
Add regression test for attrs plugin
seddonym Jan 2, 2024
22777be
Don't remove modules with descendants
meshy Jan 2, 2024
64cbe6b
Remove unrequired changes to reprocess_nodes
meshy Jan 11, 2024
6e34703
Merge branch 'master' into unexpected-unused-type-ignore
hauntsaninja Apr 2, 2025
6c378b1
Merge branch 'master' into unexpected-unused-type-ignore
ilevkivskyi Jun 20, 2025
d58936a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 20, 2025
6dd9c2e
Delete part that is likely not needed anymore
ilevkivskyi Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unrequired changes to reprocess_nodes 
The problem this solved has been addressed in another way, so we don't
need to do this re-analysis any more in order to fix the bug we've been
chasing.

This change is a partial revert of "Fix disappearing errors when
re-running dmypy check" from a few commits back.
  • Loading branch information
@meshy
meshy committed Jan 11, 2024
commit 64cbe6b360f45af33e15b418cb739c60db6aa3ae
4 changes: 0 additions & 4 deletions mypy/server/update.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1030,10 +1030,6 @@ def key(node: FineGrainedDeferredNode) -> int:
if graph[module_id].type_checker().check_second_pass():
more = True

graph[module_id].detect_possibly_undefined_vars()
graph[module_id].generate_unused_ignore_notes()
graph[module_id].generate_ignore_without_code_notes()

if manager.options.export_types:
manager.all_types.update(graph[module_id].type_map())

Expand Down