Skip to content

PEP 791: address PEP review comments (part 2) #4522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2025

Conversation

skirpichev
Copy link
Contributor

@skirpichev skirpichev commented Aug 5, 2025

  • emphasize: no backward-incompatible changes
  • expand history of the proposal
  • Motivation: what people should expect about factorial() output?
  • add n_div() proposal, rename ceil_div() like gmpy2
  • Change is either:
    • To a Draft PEP
    • To an Accepted or Final PEP, with Steering Council approval
    • To fix an editorial issue (markup, typo, link, header, etc)
  • PR title prefixed with PEP number (e.g. PEP 123: Summary of changes)

📚 Documentation preview 📚: https://pep-previews--4522.org.readthedocs.build/pep-0791/

* emphasize: no backward-incompatible changes
* expand history of the proposal
* Motivation: what people should expect about factorial() output?
* add n_div() proposal, rename ceil_div() like gmpy2
@skirpichev skirpichev requested a review from vstinner as a code owner August 5, 2025 16:28
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skirpichev
Copy link
Contributor Author

Once merged, I'll update PEP discussion thread, as suggested in #4430 (comment)

@vstinner vstinner merged commit be15a36 into python:main Aug 8, 2025
5 checks passed
@vstinner
Copy link
Member

vstinner commented Aug 8, 2025

Merged, thanks.

@skirpichev skirpichev deleted the pep791-edits branch August 8, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants