Mark stub-only private symbols as @type_check_only in third-party stubs
#14545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianschubert
commented
Aug 7, 2025
Comment on lines
-12
to
-15
| class _DatetimeWithFold(datetime): | ||
| @property | ||
| def fold(self): ... | ||
|
|
There was a problem hiding this comment.
_DatetimeWithFold only exists in Python <3.6
Comment on lines
-6
to
7
| @runtime_checkable | ||
| @type_check_only | ||
| class _Readable(Protocol): |
There was a problem hiding this comment.
Likely a typo for @type_check_only - _Readable didn't exist at the time when it was added to the stubs
Comment on lines
-62
to
-70
| class _FieldMaskTree: | ||
| def __init__(self, field_mask: Incomplete | None = ...) -> None: ... | ||
| def MergeFromFieldMask(self, field_mask: tAny) -> None: ... | ||
| def AddPath(self, path: tAny): ... | ||
| def ToFieldMask(self, field_mask: tAny) -> None: ... | ||
| def IntersectPath(self, path: tAny, intersection: tAny): ... | ||
| def AddLeafNodes(self, prefix: tAny, node: tAny) -> None: ... | ||
| def MergeMessage(self, source: tAny, destination: tAny, replace_message: tAny, replace_repeated: tAny) -> None: ... | ||
|
|
There was a problem hiding this comment.
Formerly an actual private type, since removed
Comment on lines
-49
to
-50
| class _BetaConfiguration(SetuptoolsWarning): ... | ||
| class _InvalidFile(SetuptoolsWarning): ... |
There was a problem hiding this comment.
Formerly actual private type, since removed
| @@ -77,4 +77,3 @@ class _NamespaceInstaller(namespaces.Installer): | |||
|
|
|||
| class InformationOnly(SetuptoolsWarning): ... | |||
| class LinksNotSupported(errors.FileError): ... | |||
| class _DebuggingTips(SetuptoolsWarning): ... | |||
There was a problem hiding this comment.
Formerly an actual private type, since removed
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the third-party stubtest errors from python/mypy#19574.
Mostly obvious cases like stub-only Protocols or TypedDicts. I've added inline comments to some of the less obvious cases that took some investigation.