Skip to content

fix(controls): make sure msg_id is not undefined in error case #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2025

Conversation

spaceone
Copy link
Contributor

@spaceone spaceone commented Aug 7, 2025

No description provided.

mistotebe
mistotebe previously approved these changes Aug 7, 2025
Copy link
Contributor

@mistotebe mistotebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

droideck
droideck previously approved these changes Aug 7, 2025
Copy link
Contributor

@droideck droideck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, looks good to me too!

@spaceone spaceone dismissed stale reviews from droideck and mistotebe via e7bac86 August 7, 2025 20:45
@spaceone spaceone force-pushed the fix/abandon-error-handling branch from e0af43a to e7bac86 Compare August 7, 2025 20:45
@droideck droideck merged commit a201133 into python-ldap:main Aug 7, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants