Fix #309: Make some functions private #320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomschr
added
the
Enhancement
tomschr
force-pushed
the
feature/309-private-functions
branch
from
b65619d to
42fd668
Compare
tlaferriere
suggested changes
Nov 10, 2020
Make private function in semver.version module: * Rename comparator -> _comparator, cmp -> _cmp * Remove ensure_str and integrate it into Version.parse * Rework tests in test_typeerror-274.py * Move _nat_cmp to Version and make it a class method * Remove private functions from API documentation
tomschr
force-pushed
the
feature/309-private-functions
branch
from
42fd668 to
201d783
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #309 and contains:
comparator->_comparator,cmp->_cmpensure_strand integrate it intoVersion.parsetest_typeerror-274.py_nat_cmptoVersionand make it a class method