Skip to content

Simplify max_ver and min_ver #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2023
Merged

Simplify max_ver and min_ver #401

merged 1 commit into from
Apr 2, 2023

Conversation

tomschr
Copy link
Member

@tomschr tomschr commented Apr 2, 2023 •
edited
Loading

Use max() and min() with argument key=Version.parse. This makes the two functions consistent.

@tomschr
Simplify max_ver and min_ver
c72c50c 
Use max() and min() with argument key=Version.parse
@tomschr tomschr added Release_3.x.y Only for the major release 3 Enhancement Not a bug, but increases or improves in value, quality, desirability, or attractiveness labels Apr 2, 2023
@tomschr tomschr self-assigned this Apr 2, 2023
@tomschr tomschr marked this pull request as ready for review April 2, 2023 07:21
@tomschr tomschr merged commit c40b6a4 into python-semver:master Apr 2, 2023
@tomschr tomschr deleted the min_max_ver branch April 2, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tomschr tomschr

Labels
Enhancement Not a bug, but increases or improves in value, quality, desirability, or attractiveness Release_3.x.y Only for the major release 3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tomschr