Enable all SIM rules except disabled ones #164645
Conversation
cyyever
requested review from
bobrenjc93,
laithsakka,
avikchaudhuri,
tugsbayasgalan,
zhxchen17,
ydwu4,
angelayi,
sraikund16,
zou3519,
mruberry,
titaiwangms,
justinchuby,
jerryzh168,
albanD,
janeyx99,
jbschlosser and
mikaylagawarecki
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164645
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit eedc2d4 with merge base cf0a00d ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/inductor
module: dynamo
module: inductor
oncall: distributed
cyyever
changed the title
Signed-off-by: Yuanyuan Chen <[email protected]>
|
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 1 checks: inductor / inductor-test / test (inductor_torchbench, 2, 2, linux.g5.4xlarge.nvidia.gpu) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m "causes lint failures" -c nosignal see probably enabling "SIM" is too wide? |
|
@pytorchbot successfully started a revert job. Check the current status here. |
This reverts commit 321e602. Reverted #164645 on behalf of https://github.com/izaitsevfb due to causes lint failures ([comment](#164645 (comment)))
|
@cyyever your PR has been successfully reverted. |
cyyever
requested review from
divyanshk,
ramanishsingh,
a team,
soulitzer,
fmassa and
malfet
as code owners
cyyever
force-pushed
the
ruff_sim2
branch
3 times, most recently
from
eab1fda to
4db52ec
Compare
Signed-off-by: Yuanyuan Chen <[email protected]>
SIMrules are useful for simplifying boolean expressions and enhances code readability.cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta @msaroufim @dcci @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @jerryzh168 @ezyang @EikanWang @wenzhe-nrv @voznesenskym @penguinwu @Guobing-Chen @zhuhaozhe @blzheng @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @Lucaskabela