Add proper warning about missing Infinispan client#52441
Merged
gastaldi merged 3 commits intoquarkusio:mainfrom Feb 7, 2026
Merged
Add proper warning about missing Infinispan client#52441gastaldi merged 3 commits intoquarkusio:mainfrom
gastaldi merged 3 commits intoquarkusio:mainfrom
Conversation
Contributor
geoand
commented
Feb 6, 2026
geoand
commented
- Closes: Infinispan client with disabled devservices failing to start in dev mode #52431
Member
|
@geoand thanks ! I was going to deal with it but nice ! |
karesti
reviewed
Feb 6, 2026
| return infinispanClientProducer.getNamedRemoteCacheManager(clientName); | ||
| RemoteCacheManager result = infinispanClientProducer.getNamedRemoteCacheManager(clientName); | ||
| if (result == null) { | ||
| if (clientName.startsWith(InfinispanClientUtil.DEFAULT_INFINISPAN_CLIENT_NAME)) { |
Contributor
Author
There was a problem hiding this comment.
It allows to print a better error message
Member
There was a problem hiding this comment.
I believe it can be done in a single line without the if, but ok
Status for workflow
|
karesti
approved these changes
Feb 6, 2026
gastaldi
approved these changes
Feb 7, 2026
Member
|
Let's include in 3.32 only as there are conflicts on backport. |
Member
Member
|
Ah sorry, I was the one that added the backport label but haven't checked that the original one was not marked for backport. Let's have it in 3.32 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.