-
Notifications
You must be signed in to change notification settings - Fork 195
Comparing changes
Open a pull request
base repository: que-rb/que
base: v2.2.1
head repository: que-rb/que
compare: v2.3.0
- 20 commits
- 16 files changed
- 5 contributors
Commits on May 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7e3d436 - Browse repository at this point
Copy the full SHA 7e3d436View commit details
Commits on May 19, 2023
-
Improve QueJob#by_job_class performance.
This method wasn't making use of the que_jobs.args index and was performing badly on large datasets. GIN indexes don't support the '=' operator, but support existence '?' and containment '@>' among others. To make use of the index the query has to check for containment of a subset document rather than match a value within the document directly. QueJob#by_job_args is already querying in this way; this change makes QueJob#by_job_class consistent with it. Context: https://www.postgresql.org/docs/9.6/datatype-json.html#JSON-INDEXING Given a jsonb column "data" indexed as follows: CREATE INDEX data_index ON table USING GIN (data); And with data in this format: { "name": "Melbourne", "type": "City" } This query will make use of the index: SELECT data FROM table WHERE data @> '{"name": "Melbourne"}'; But this one will not: SELECT data FROM table WHERE data->>'name' = "Melbourne";
Configuration menu - View commit details
-
Copy full SHA for 9c140bf - Browse repository at this point
Copy the full SHA 9c140bfView commit details
Commits on Jul 5, 2023
-
Merge pull request #394 from ferocia/dtcristo/improve-by-job-class-perf
Improve `QueJob#by_job_class` performance.
Configuration menu - View commit details
-
Copy full SHA for 9b26406 - Browse repository at this point
Copy the full SHA 9b26406View commit details -
Allow que to be started without listen/notify
Ability to disable listen/noify on CLI resulting in jobs being picked up purely from polling. We have seen issues with listen/notify usage at scale.
Configuration menu - View commit details
-
Copy full SHA for 2593d92 - Browse repository at this point
Copy the full SHA 2593d92View commit details
Commits on Sep 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 21d373f - Browse repository at this point
Copy the full SHA 21d373fView commit details -
Merge pull request #398 from que-rb/list-que-prometheus-in-readme
List que-prometheus in readme
Configuration menu - View commit details
-
Copy full SHA for 9744019 - Browse repository at this point
Copy the full SHA 9744019View commit details
Commits on Oct 9, 2023
-
Fix specificity of Rails versions in spec gemfiles
The Gemfile that's supposed to test Rails 7.0 was running Rails 7.1 🤦 ``` Installing activejob 7.1.0 ``` https://github.com/que-rb/que/actions/runs/6456183723/job/17525155590?pr=401#step:5:87
Configuration menu - View commit details
-
Copy full SHA for 186d28a - Browse repository at this point
Copy the full SHA 186d28aView commit details -
Merge pull request #402 from que-rb/fix-specificity-of-rails-versions…
…-in-spec-gemfiles Fix specificity of Rails versions in spec gemfiles
Configuration menu - View commit details
-
Copy full SHA for 4e08e84 - Browse repository at this point
Copy the full SHA 4e08e84View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d7db7e - Browse repository at this point
Copy the full SHA 2d7db7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3792e54 - Browse repository at this point
Copy the full SHA 3792e54View commit details -
Copy in ActiveJob::QueueAdapters::QueAdapter from Rails removal
This no longer exists in Rails, but is still needed. I simply copied the class from the [removal PR](rails/rails#46005), and removed the unnecessary comments, and adjusted the formatting slightly. (Tests not yet passing)
Configuration menu - View commit details
-
Copy full SHA for 9de3b96 - Browse repository at this point
Copy the full SHA 9de3b96View commit details -
Get copied-in ActiveJob::QueueAdapters::QueAdapter working
I'd thought we'd need to now use `ActiveJob::Base.queue_adapter = ActiveJob::QueueAdapters::QueAdapter.new` rather than `ActiveJob::Base.queue_adapter = :que`, but it seems that by keeping the adapter class namespace unchanged, we can still use the latter.
Configuration menu - View commit details
-
Copy full SHA for ba5fe8c - Browse repository at this point
Copy the full SHA ba5fe8cView commit details -
Simplify ActiveJob::QueueAdapters::QueAdapter slightly by removing #r…
…equire_job_options_kwarg? We don't need to support old versions of Que in the adapter anymore! Que's codebase always uses the latest Que =P I considered removing & inlining Que::ActiveJob::WrapperExtensions::ClassMethods#enqueue into our Rails 7.1+ QueAdapter, but it still needs to exist in place for support for older versions of Rails =\ Keeping it in place conditionally based on the Rails version would be [a bit complex](#399 (comment)), and so perhaps not an improvement.
Configuration menu - View commit details
-
Copy full SHA for 0c66d03 - Browse repository at this point
Copy the full SHA 0c66d03View commit details
Commits on Oct 16, 2023
-
Merge pull request #395 from ferocia/dtcristo/diable-listen-on-cli
Allow que to be started without listen/notify
Configuration menu - View commit details
-
Copy full SHA for d58b3f4 - Browse repository at this point
Copy the full SHA d58b3f4View commit details -
Merge pull request #403 from que-rb/support-rails-7.1
Support Rails 7.1+ by adding ActiveJob Que adapter removed from Rails
Configuration menu - View commit details
-
Copy full SHA for 4360dff - Browse repository at this point
Copy the full SHA 4360dffView commit details -
Merge pull request #393 from tomgi/run_synchronously_dont_clear_conne…
…ction Don't clear ActiveRecord connections when run_synchronously is enabled
Configuration menu - View commit details
-
Copy full SHA for 218149a - Browse repository at this point
Copy the full SHA 218149aView commit details -
Temporarily restict rails version to 7.1.0 for 7.1 tests
See this comment for more info: https://github.com/que-rb/que/pull/403\#issuecomment-1764134027
Configuration menu - View commit details
-
Copy full SHA for d660b58 - Browse repository at this point
Copy the full SHA d660b58View commit details -
Merge pull request #405 from que-rb/fix-build
Temporarily restict rails version to 7.1.0 for 7.1 tests
Configuration menu - View commit details
-
Copy full SHA for 90800bd - Browse repository at this point
Copy the full SHA 90800bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 59b0974 - Browse repository at this point
Copy the full SHA 59b0974View commit details -
Configuration menu - View commit details
-
Copy full SHA for bcec606 - Browse repository at this point
Copy the full SHA bcec606View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v2.2.1...v2.3.0