Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: que-rb/que
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.2.1
Choose a base ref
...
head repository: que-rb/que
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.3.0
Choose a head ref
  • 20 commits
  • 16 files changed
  • 5 contributors

Commits on May 18, 2023

  1. Configuration menu
    Copy the full SHA
    7e3d436 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2023

  1. Improve QueJob#by_job_class performance.

    This method wasn't making use of the que_jobs.args index and was
    performing badly on large datasets.
    
    GIN indexes don't support the '=' operator, but support existence '?'
    and containment '@>' among others. To make use of the index the query
    has to check for containment of a subset document rather than match a
    value within the document directly.
    
    QueJob#by_job_args is already querying in this way; this change makes
    QueJob#by_job_class consistent with it.
    
    Context:
    
    https://www.postgresql.org/docs/9.6/datatype-json.html#JSON-INDEXING
    
    Given a jsonb column "data" indexed as follows:
      CREATE INDEX data_index ON table USING GIN (data);
    
    And with data in this format:
      {
        "name": "Melbourne",
        "type": "City"
      }
    
    This query will make use of the index:
      SELECT data FROM table WHERE data @> '{"name": "Melbourne"}';
    
    But this one will not:
      SELECT data FROM table WHERE data->>'name' = "Melbourne";
    benhoskings authored and dtcristo committed May 19, 2023
    Configuration menu
    Copy the full SHA
    9c140bf View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Merge pull request #394 from ferocia/dtcristo/improve-by-job-class-perf

    Improve `QueJob#by_job_class` performance.
    oeoeaio authored Jul 5, 2023
    Configuration menu
    Copy the full SHA
    9b26406 View commit details
    Browse the repository at this point in the history
  2. Allow que to be started without listen/notify

    Ability to disable listen/noify on CLI resulting in jobs
    being picked up purely from polling. We have seen issues
    with listen/notify usage at scale.
    anthony authored and dtcristo committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    2593d92 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. List que-prometheus in readme

    ZimbiX committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    21d373f View commit details
    Browse the repository at this point in the history
  2. Merge pull request #398 from que-rb/list-que-prometheus-in-readme

    List que-prometheus in readme
    ZimbiX authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    9744019 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Fix specificity of Rails versions in spec gemfiles

    The Gemfile that's supposed to test Rails 7.0 was running Rails 7.1 🤦
    
    ```
    Installing activejob 7.1.0
    ```
    
    https://github.com/que-rb/que/actions/runs/6456183723/job/17525155590?pr=401#step:5:87
    ZimbiX committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    186d28a View commit details
    Browse the repository at this point in the history
  2. Merge pull request #402 from que-rb/fix-specificity-of-rails-versions…

    …-in-spec-gemfiles
    
    Fix specificity of Rails versions in spec gemfiles
    ZimbiX authored Oct 9, 2023
    Configuration menu
    Copy the full SHA
    4e08e84 View commit details
    Browse the repository at this point in the history
  3. Run tests on Rails 7.1

    ZimbiX committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    2d7db7e View commit details
    Browse the repository at this point in the history
  4. Use Rails 7.1 in Gemfile

    (Tests not yet passing)
    ZimbiX committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    3792e54 View commit details
    Browse the repository at this point in the history
  5. Copy in ActiveJob::QueueAdapters::QueAdapter from Rails removal

    This no longer exists in Rails, but is still needed. I simply copied the class from the [removal PR](rails/rails#46005), and removed the unnecessary comments, and adjusted the formatting slightly.
    
    (Tests not yet passing)
    ZimbiX committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    9de3b96 View commit details
    Browse the repository at this point in the history
  6. Get copied-in ActiveJob::QueueAdapters::QueAdapter working

    I'd thought we'd need to now use `ActiveJob::Base.queue_adapter = ActiveJob::QueueAdapters::QueAdapter.new` rather than `ActiveJob::Base.queue_adapter = :que`, but it seems that by keeping the adapter class namespace unchanged, we can still use the latter.
    ZimbiX committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    ba5fe8c View commit details
    Browse the repository at this point in the history
  7. Simplify ActiveJob::QueueAdapters::QueAdapter slightly by removing #r…

    …equire_job_options_kwarg?
    
    We don't need to support old versions of Que in the adapter anymore! Que's codebase always uses the latest Que =P
    
    I considered removing & inlining Que::ActiveJob::WrapperExtensions::ClassMethods#enqueue into our Rails 7.1+ QueAdapter, but it still needs to exist in place for support for older versions of Rails =\ Keeping it in place conditionally based on the Rails version would be [a bit complex](#399 (comment)), and so perhaps not an improvement.
    ZimbiX committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    0c66d03 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Merge pull request #395 from ferocia/dtcristo/diable-listen-on-cli

    Allow que to be started without listen/notify
    oeoeaio authored Oct 16, 2023
    Configuration menu
    Copy the full SHA
    d58b3f4 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #403 from que-rb/support-rails-7.1

    Support Rails 7.1+ by adding ActiveJob Que adapter removed from Rails
    oeoeaio authored Oct 16, 2023
    Configuration menu
    Copy the full SHA
    4360dff View commit details
    Browse the repository at this point in the history
  3. Merge pull request #393 from tomgi/run_synchronously_dont_clear_conne…

    …ction
    
    Don't clear ActiveRecord connections when run_synchronously is enabled
    oeoeaio authored Oct 16, 2023
    Configuration menu
    Copy the full SHA
    218149a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d660b58 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #405 from que-rb/fix-build

    Temporarily restict rails version to 7.1.0 for 7.1 tests
    oeoeaio authored Oct 16, 2023
    Configuration menu
    Copy the full SHA
    90800bd View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    59b0974 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    bcec606 View commit details
    Browse the repository at this point in the history
Loading