Improve QueJob#by_job_class performance.
#394
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method wasn't making use of the
que_jobs.argsindex and was performing badly on large datasets.GIN indexes don't support the
=operator, but support existence?and containment@>among others. To make use of the index the query has to check for containment of a subset document rather than match a value within the document directly.QueJob#by_job_argsis already querying in this way; this change makesQueJob#by_job_classconsistent with it.Context:
https://www.postgresql.org/docs/9.6/datatype-json.html#JSON-INDEXING
Given a jsonb column "data" indexed as follows:
And with data in this format:
{ "name": "Melbourne", "type": "City" }This query will make use of the index:
But this one will not: