Skip to content

Add reference to Japanese translation on the homepage #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gemmaro
Copy link

@gemmaro gemmaro commented Jun 24, 2025

Hello,

I've translated the following rbenv-related repositories into Japanese to support Japanese-speaking developers:

This adds a link to the Japanese translation page on the respective top page.

Thank you,

Copy link
Member

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thank you for working hard on the translations!

I would feel better about having a translation on the rbenv.org site itself, rather than linking to a separate site that is a fork. That way I believe the content could stay up-to-date in the long term and contributed to in the central repository (this one).

Does that sound good and would you be open to restructure your PR so that it adds translations of index.html and rbenv/ruby-build man pages under the https://rbenv.org/ja/ URL? Also, the po4a recipes could be added to our existing Makefile in the root directory, rather than being in a separate Makefile. Thank you!

Additionally, I don't think it's necessary to call out to the existence of "Ruby STUDIO/rbenv". That page is severely out of date and, since we're not affiliated with it and since you haven't borrowed translations from there, I would suggest to not mention it at all to avoid confusion.

@gemmaro
Copy link
Author

gemmaro commented Jun 25, 2025

Thank you for your feedback!

I agree with keeping the translation on rbenv.org to ensure it stays up-to-date, and I’m on board with the proposed URL structure for the localized pages.
I’ll also remove the links to the previous translation works as you suggested.

Here’s my proposed plan. Does it sound okay to proceed?

  1. Add translation sources and corresponding Make tasks to the rbenv and ruby-build repositories.
  2. Add translation sources and Make tasks to this repository as well --- including pulling translations from the rbenv and ruby-build directories.

@gemmaro
Copy link
Author

gemmaro commented Jul 5, 2025

Hi, I’ve opened the pull request rbenv/rbenv#1624 to get your feedback on whether the overall direction looks good.
If this approach seems appropriate, I’d like to go ahead and open similar pull requests for the ruby-build and this rbenv.github.io repositories as well.
Thanks in advance for taking a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants