Typing for watch & getValues #5005
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4994
For reference, here is the sandbox that shows the issue
As explained in the issue mentioned above, this PR make use of TS variadic tuple types to extract the proper type of the tuple returned by
watch
&getValues
To avoid any potential breaking changes on
watch
type definition, I've kept the previously defined signatures.The behaviour if this gets merged would be as follow
getValues
:watch
:Ps: First time contributing to an open source project, happy to take any advices :)