Skip to content

Conversation

mununki
Copy link
Member

@mununki mununki commented Sep 23, 2024

@mununki mununki changed the title Deprecate JSX v3 Deprecate JSX 3 Sep 23, 2024
@mununki
Copy link
Member Author

mununki commented Sep 23, 2024

@cknitt Let me test with small repo project before merging. I'd like to check whether the deprecation msg seems too annoying for user.

@mununki
Copy link
Member Author

mununki commented Sep 30, 2024

@cknitt When I ran it on a small-scale test project, a lot of warnings appeared. Unless I disable the warnings, it seems like it would be quite annoying. Is this okay?
image

@cknitt
Copy link
Member

cknitt commented Feb 22, 2025

@mununki Sorry, I lost track of this. I think this is fine, after all we want people to migrate to JSX 4, and they can always disable deprecation warnings altogether.

@cknitt cknitt merged commit 479679f into master Feb 22, 2025
1 check passed
@cknitt cknitt deleted the deprecate-v3 branch February 22, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants