Implement a Socket::Credentials struct for handling unix socket creds #6822
+901
−128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KJTsanaktsidis
force-pushed
the
ktsanaktsidis/recv_io_multi
branch
5 times, most recently
from
d21165b to
294f8c2
Compare
KJTsanaktsidis
changed the title
KJTsanaktsidis
force-pushed
the
ktsanaktsidis/recv_io_multi
branch
from
294f8c2 to
69ab0fa
Compare
Depending on the platform, Unix sockets can support fetching the credentials of a remote peer, or pushing credentials to a remote peer, through a variety of socket options and ancillary message types. Currently, Ruby is able to parse these ancillary data and socket option structures, but the only way this is exposed back to Ruby code is through the #inspect method. Parsing inspect strings is not a robust way to write programs! This change adds a type Socket::Credentials, which is a structure for holding the various kinds of credentials that unixen support passing between processes. It also implements Socket::AncillaryData#credentials and Socket::Option#credentials, to allow parsing these credentials from ancillary data/socket options respectively.
KJTsanaktsidis
force-pushed
the
ktsanaktsidis/recv_io_multi
branch
from
69ab0fa to
449045b
Compare
|
Oh this is pretty neat. |
|
Hey @ioquatix , now that 3.2 has been released, wondering if you could have a squizz at this? Thanks! |
|
Yup, I already had a ticket open for this from last year - nobody looked at it! 😢 https://bugs.ruby-lang.org/issues/19179. Figured it was too close to Ruby 3.2 release and everyone was focused on that. I'm not sure how to actually ping people on redmine to take a look though, i can't seem to tag or assign anybody? |
|
We should add it to the next developer meeting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on the platform, Unix sockets can support fetching the credentials of a remote peer, or pushing credentials to a remote peer, through a variety of socket options and ancillary message types.
Currently, Ruby is able to parse these ancillary data and socket option structures, but the only way this is exposed back to Ruby code is through the
#inspectmethod. Parsing inspect strings is not a robust way to write programs!This change adds a type
Socket::Credentials, which is a structure for holding the various kinds of credentials that unixen support passing between processes. It also implementsSocket::AncillaryData#credentialsandSocket::Option#credentials, to allow parsing these credentials from ancillary data/socket options respectively.fixes https://bugs.ruby-lang.org/issues/19179