Skip to content

Added method to get a duplicate of the internal Hash #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 29, 2020
Merged

Added method to get a duplicate of the internal Hash #286

merged 1 commit into from
Aug 29, 2020

Conversation

thorsteneckel
Copy link
Contributor

This aims to avoid constructs like this:

attributes = {}
ldap.search_root_dse.each { |key, value|
  attributes[key] = value
}
attributes

Which now will look like:

ldap.search_root_dse.to_h

HarlemSquirrel
HarlemSquirrel approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@HarlemSquirrel HarlemSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! I think we should merge this in after our next patch release and include this in a minor release since it's a new feature.

@HarlemSquirrel HarlemSquirrel added this to the v0.17 milestone Jul 9, 2020
HarlemSquirrel
HarlemSquirrel approved these changes Aug 29, 2020
View reviewed changes
Copy link
Member

@HarlemSquirrel HarlemSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@HarlemSquirrel HarlemSquirrel merged commit a86cc32 into ruby-ldap:master Aug 29, 2020
@dependabot dependabot bot mentioned this pull request Mar 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarlemSquirrel HarlemSquirrel HarlemSquirrel approved these changes

Assignees
No one assigned
Labels
Feature Requests
Projects
None yet
Milestone
v0.17
Development

Successfully merging this pull request may close these issues.
2 participants
@thorsteneckel @HarlemSquirrel