Update documentation for requisites #49962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@garethgreenaway Could you please make sure the description of |
MTecknology
changed the title
MTecknology
changed the title
cachedout
reviewed
Oct 16, 2018
garethgreenaway
approved these changes
Oct 19, 2018
|
@garethgreenaway Excellent, thanks for checking! |
|
@cachedout ping? I believe I resolved all of your concerns. Do you have any others? |
cachedout
approved these changes
Oct 23, 2018
garethgreenaway
added a commit
to garethgreenaway/salt
that referenced
this pull request
Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Organize and clean-up documentation.
A lot of the requisites didn't make sense to me and I struggled to understand why one would be chosen over the other because they mostly sounded the same. I tried to work through a layman explanation of what makes each requisite special.
I also attempted to consolidate repetitive explanations, remove overly-technical bits, and re-arrange things so they're easier to navigate.
Hopefully all of my changes are helpful and technically accurate, but added explanations are to the best of my comprehension, so review would be excellent.
Commits signed with GPG?
Yes